Suppress highlighting for completed filter in todo.txt dialogs #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshad1
force-pushed
the
suppress_highlighting_for_done_filter
branch
from
5761544 to
fe735f2
Compare
harshad1
force-pushed
the
suppress_highlighting_for_done_filter
branch
from
fe735f2 to
7518e0e
Compare
gsantner
reviewed
Jul 8, 2022
app/src/main/java/net/gsantner/markor/ui/SearchOrCustomTextDialogCreator.java
Show resolved
Hide resolved
|
No. Only for the Completed filter.
Jul. 8, 2022 15:25:11 Gregor Santner ***@***.***>:
… ***@***.**** commented on this pull request.
----------------------------------------
In app/src/main/java/net/gsantner/markor/ui/SearchOrCustomTextDialogCreator.java[#1754 (comment)]:
> @@ -271,6 +271,7 @@ public static void showSttFilteringDialog(final Activity activity, final EditTex
icons.add(R.drawable.ic_check_black_24dp);
callbacks.add(() -> {
final SearchOrCustomTextDialog.DialogOptions dopt2 = makeSttLineSelectionDialog(activity, text, TodoTxtTask::isDone);
+ dopt2.highlighter = null; // Don't need the grey + strikeout highlighting. Makes it harder to see.
doesn't this kill highlighting generally - like also +/@/dates?
—
Reply to this email directly, view it on GitHub[#1754 (review)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAOZ3TDPM34BNWPHHPR2DVLVTCTEJANCNFSM527PECDA].
You are receiving this because you authored the thread.[Tracking image][https://github.com/notifications/beacon/AAOZ3TARAMGVE56W7WVHIZDVTCTEJA5CNFSM527PECDKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOHWMMW6Q.gif]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small tweak for better visibility